Allow read-only access ('kubectl get') on rbac roles and rolebindings #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested in my own namespace on dev cluster. Before: ## executed as k8s admin:
$ kc get -o yaml -n brooke role brookeapiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
## [...etc...]
rules:
- apiGroups:
- ""
- networking.k8s.io
- extensions
- apps
- autoscaling
resources:
- '*'
verbs:
- '*'
- apiGroups:
- batch
resources:
- jobs
- cronjobs
verbs:
- '*'After: ## executed as k8s admin:
$ cat application-context.yaml | SERVICE_ACCOUNT=brooke envsubst | kubectl apply -n brooke -f -
serviceaccount/brooke unchanged
role.rbac.authorization.k8s.io/brooke configured
rolebinding.rbac.authorization.k8s.io/brooke unchanged
$ kc get -o yaml -n brooke role brookeapiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
## [...etc...]
rules:
- apiGroups:
- ""
- networking.k8s.io
- extensions
- apps
- autoscaling
resources:
- '*'
verbs:
- '*'
- apiGroups:
- batch
resources:
- jobs
- cronjobs
verbs:
- '*'
- apiGroups:
- rbac.authorization.k8s.io
resources:
- roles
- rolebindings
verbs:
- get(Last 7 lines added) |
|
Looks good to me. Do you have a list of existing service accounts to apply this to to make sure they all have it? And is it worthwhile to automate that process of adding the additional perms to existing service accounts? |
mbjones
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #48